util/agents/usb_hid_relay: Fix agent errors #1776
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1776 +/- ##
=========================================
- Coverage 56.0% 45.2% -10.9%
=========================================
Files 170 172 +2
Lines 13307 13572 +265
=========================================
- Hits 7458 6136 -1322
- Misses 5849 7436 +1587
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Emantor
force-pushed
the
usb_hid_relay_issue
branch
from
e5b5425 to
423b8c2
Compare
Emantor
reviewed
Nov 21, 2025
* get_output() should return some result; * should attach kernel driver back in the destructor otherwise HIDRAW device will not appear if it has existed. Signed-off-by: Roman Kuznecov <[email protected]>
cidlik
force-pushed
the
usb_hid_relay_issue
branch
from
423b8c2 to
980a992
Compare
Emantor
approved these changes
Nov 22, 2025
Contributor
Author
|
Hello there! @jluebbe, can you review the change, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TL;DR
Hello there! I have a USB HID relay and tests for it and I face with the issue when after labgrid using the relay will not display in /dev system. Only replugging helps to fix it.
I notice that the device attachment is not performed at the USBHIDRelay destructor, and it seems to me ambiguous because the device doesn't return to the initial state.
I ran multiple pytest processes to test concurrent situations which were fixed in 1526. Tests are passed.
Checklist